Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ParseError Much Simpler now that we can use TypeScript #14796

Merged
merged 8 commits into from
Jul 25, 2022
Merged

Make ParseError Much Simpler now that we can use TypeScript #14796

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dc24c3f
Dramatically simplify ParseError and associated ParseErrorTemplates n…
tolmasky Jul 25, 2022
14e7796
Fix lint error.
tolmasky Jul 25, 2022
9ed5f69
A minor change to make this less verbose.
tolmasky Jul 25, 2022
b8ed13b
Add a comment explaining why we inline the type definition instead of…
tolmasky Jul 25, 2022
ae3d447
Use inferred type instead of unknown.
tolmasky Jul 25, 2022
adcef9c
Better comments and clean up some errors in a better way.
tolmasky Jul 25, 2022
afbaa2c
Use SyntaxPlugin everywhere. TypeScript doesn't seem to care either w…
tolmasky Jul 25, 2022
c5f4bba
Use const enum for ParseErrorCode.
tolmasky Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use SyntaxPlugin everywhere. TypeScript doesn't seem to care either w… 
…ay, and we may want to change this back to string when we allow custom sytnax plugins (or "SyntaxPlugin | string" just to convey this a bit better, even though that would be the same).

Reviewed by @tolmasky.
  • Loading branch information
@tolmasky
tolmasky committed Jul 25, 2022
commit afbaa2cfef1ad66252314464718bb0979a435a09
4 changes: 2 additions & 2 deletions packages/babel-parser/src/parse-error.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ interface ParseErrorSpecification<ErrorDetails> {
// as readonly, so let's just not worry about it for now.
code: ParseErrorCode;
reasonCode: string;
syntaxPlugin?: string;
syntaxPlugin?: SyntaxPlugin;
missingPlugin?: string | string[];
loc: Position;
details: ErrorDetails;
Expand Down Expand Up @@ -130,7 +130,7 @@ export function ParseErrorEnum(a: TemplateStringsArray): <

export function ParseErrorEnum<T extends ParseErrorTemplates>(
parseErrorTemplates: T,
syntaxPlugin?: string,
syntaxPlugin?: SyntaxPlugin,
): {
[K in keyof T]: ParseErrorConstructor<
T[K] extends { message: string | ToMessage<any> }
Expand Down