Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ts] Support private methods overloads #13876

Merged
merged 4 commits into from
Oct 26, 2021
+316 −1
Merged

[ts] Support private methods overloads #13876

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
12686fa
[parser] Allow private methods overloads when parsing TS
nicolo-ribaudo Oct 23, 2021
053e45d
Add transform tests
nicolo-ribaudo Oct 23, 2021
73151fc
Fix estree
nicolo-ribaudo Oct 24, 2021
8e81cf0
Fix flow
nicolo-ribaudo Oct 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add transform tests
  • Loading branch information
@nicolo-ribaudo
nicolo-ribaudo committed Oct 23, 2021
commit 053e45dbf131643c0a0450a5a88c1adabf3dbc73
7 changes: 7 additions & 0 deletions ...ansform-typescript/test/fixtures/class/private-method-override-transform-private/input.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
class Test {
#f(x: string): number;
#f(x: number): string;
#f(x: string | number): string | number {
return (typeof x === 'string') ? parseInt(x) : x.toString();
}
}
3 changes: 3 additions & 0 deletions ...orm-typescript/test/fixtures/class/private-method-override-transform-private/options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"plugins": ["transform-typescript", "proposal-private-methods"]
}
12 changes: 12 additions & 0 deletions ...nsform-typescript/test/fixtures/class/private-method-override-transform-private/output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
var _f = /*#__PURE__*/new WeakSet();

class Test {
constructor() {
babelHelpers.classPrivateMethodInitSpec(this, _f);
}

}

function _f2(x) {
return typeof x === 'string' ? parseInt(x) : x.toString();
}
7 changes: 7 additions & 0 deletions ...es/babel-plugin-transform-typescript/test/fixtures/class/private-method-override/input.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
class Test {
#f(x: string): number;
#f(x: number): string;
#f(x: string | number): string | number {
return (typeof x === 'string') ? parseInt(x) : x.toString();
}
}
3 changes: 3 additions & 0 deletions ...abel-plugin-transform-typescript/test/fixtures/class/private-method-override/options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"plugins": ["transform-typescript"]
}
6 changes: 6 additions & 0 deletions ...s/babel-plugin-transform-typescript/test/fixtures/class/private-method-override/output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
class Test {
#f(x) {
return typeof x === 'string' ? parseInt(x) : x.toString();
}

}