Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure babel parser throws exactly same recoverable errors when estree plugin is enabled #12375

Merged
merged 13 commits into from
Dec 3, 2020
Merged

Make sure babel parser throws exactly same recoverable errors when estree plugin is enabled #12375

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
40f488b
refactor: introduce isPrivateName and getPrivateNameSV
JLHwung Nov 17, 2020
054e7db
feat: check recoverable errors on estree-throw
JLHwung Nov 19, 2020
6dcca23
fix: pass through all params of parseBlockBody
JLHwung Nov 19, 2020
ab0e2c0
fix: set bigInt to null when invalid bigInt value is parsed
JLHwung Nov 19, 2020
3391585
fix: use string literal value in error message
JLHwung Nov 19, 2020
18eeedc
refactor: introduce hasPropertyAsPrivateName
JLHwung Nov 19, 2020
eeee5da
fix: adapt to ChainExpression
JLHwung Nov 19, 2020
356c196
fix: port checkLVal early return for method in object pattern
JLHwung Nov 19, 2020
5ddb951
fix: throw new a?.() on estree
JLHwung Nov 19, 2020
105c2cc
fix: early return for __proto__ in accessors
JLHwung Nov 19, 2020
85268f9
fix: test record element via isObjectProperty
JLHwung Nov 19, 2020
3cc4e5e
fix: pass through isLHS in toAssignable
JLHwung Nov 19, 2020
c962cb3
refactor: introduce isObjectMethod methods
JLHwung Nov 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: check recoverable errors on estree-throw
  • Loading branch information
@JLHwung
JLHwung committed Nov 19, 2020
commit 054e7db91a4bc8fdff6e2b4d125ea83757d8e472
29 changes: 26 additions & 3 deletions packages/babel-parser/test/helpers/runFixtureTests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,13 @@ export function runThrowTestsWithEstree(fixturesPath, parseFunction) {
Object.keys(fixtures).forEach(function (name) {
fixtures[name].forEach(function (testSuite) {
testSuite.tests.forEach(function (task) {
if (!task.options.throws) return;
if (!task.options.throws) {
const hasErrors =
!task.disabled && "errors" in JSON.parse(task.expect.code);
if (!hasErrors) {
return;
}
}

task.options.plugins = task.options.plugins || [];
task.options.plugins.push("estree");
Expand All @@ -92,7 +98,7 @@ export function runThrowTestsWithEstree(fixturesPath, parseFunction) {

testFn(name + "/" + testSuite.title + "/" + task.title, function () {
try {
runTest(task, parseFunction);
runTest(task, parseFunction, true);
} catch (err) {
const fixturePath = `${path.relative(
rootPath,
Expand Down Expand Up @@ -126,7 +132,19 @@ function save(test, ast) {
);
}

function runTest(test, parseFunction) {
/**
* run parser on given tests
*
* @param {Test} A {@link packages/babel-helper-fixtures/src/index.js Test} instance
generated from `getFixtures`
* @param {*} parseFunction A parser with the same interface of `@babel/parser#parse`
* @param {boolean} [compareErrorsOnly=false] Whether we should only compare the "errors"
* of generated ast against the expected AST. Used for `runThrowTestsWithEstree` where an
* ESTree AST is generated but we want to make sure `@babel/parser` still throws expected
* recoverable errors on given code locations.
* @returns {void}
*/
function runTest(test, parseFunction, compareErrorsOnly = false) {
const opts = test.options;

if (opts.throws && test.expect.code) {
Expand Down Expand Up @@ -189,6 +207,11 @@ function runTest(test, parseFunction) {
throw new Error(
"Expected error message: " + opts.throws + ". But parsing succeeded.",
);
} else if (compareErrorsOnly) {
const mis = misMatch(JSON.parse(test.expect.code).errors, ast.errors);
if (mis) {
throw new Error(mis);
}
} else {
const mis = misMatch(JSON.parse(test.expect.code), ast);

Expand Down