[babel 8] Turn const enums into const variables (#16396)

Co-authored-by: Babel Bot <30521560+liuxingbaoyu@users.noreply.github.com>
babel · Apr 1, 2024 · dd699a8 · dd699a8
1 parent 22725e9
commit dd699a8
Show file tree

Hide file tree

Showing 26 changed files with 134 additions and 7 deletions.
diff --git a/packages/babel-plugin-transform-typescript/src/const-enum.ts b/packages/babel-plugin-transform-typescript/src/const-enum.ts
@@ -52,7 +52,9 @@ export default function transpileConstEnum(
       );
     } else {
       path.replaceWith(
-        t.variableDeclaration("var", [t.variableDeclarator(path.node.id, obj)]),
+        t.variableDeclaration(process.env.BABEL_8_BREAKING ? "const" : "var", [
+          t.variableDeclarator(path.node.id, obj),
+        ]),
       );
       path.scope.registerDeclaration(path);
     }

diff --git a/...orm-typescript/test/fixtures/optimize-const-enums/custom-values-exported-babel-7/input.ts b/...orm-typescript/test/fixtures/optimize-const-enums/custom-values-exported-babel-7/input.ts
@@ -0,0 +1,11 @@
+export const enum A {
+  x = 3,
+  y = "f",
+  z = 4 << 2,
+  w = y
+}
+
+A.x;
+A.y;
+A.z;
+A.w;
diff --git a/...typescript/test/fixtures/optimize-const-enums/custom-values-exported-babel-7/options.json b/...typescript/test/fixtures/optimize-const-enums/custom-values-exported-babel-7/options.json
@@ -0,0 +1,5 @@
+{
+  "plugins": [["transform-typescript", { "optimizeConstEnums": true }]],
+  "sourceType": "module",
+  "BABEL_8_BREAKING": false
+}
diff --git a/...m-typescript/test/fixtures/optimize-const-enums/custom-values-exported-babel-7/output.mjs b/...m-typescript/test/fixtures/optimize-const-enums/custom-values-exported-babel-7/output.mjs
@@ -0,0 +1,10 @@
+export var A = {
+  x: 3,
+  y: "f",
+  z: 16,
+  w: "f"
+};
+A.x;
+A.y;
+A.z;
+A.w;
diff --git a/...ansform-typescript/test/fixtures/optimize-const-enums/custom-values-exported/options.json b/...ansform-typescript/test/fixtures/optimize-const-enums/custom-values-exported/options.json
@@ -0,0 +1,5 @@
+{
+  "plugins": [["transform-typescript", { "optimizeConstEnums": true }]],
+  "sourceType": "module",
+  "BABEL_8_BREAKING": true
+}
diff --git a/...transform-typescript/test/fixtures/optimize-const-enums/custom-values-exported/output.mjs b/...transform-typescript/test/fixtures/optimize-const-enums/custom-values-exported/output.mjs
@@ -1,4 +1,4 @@
-export var A = {
+export const A = {
   x: 3,
   y: "f",
   z: 16,

diff --git a/...ransform-typescript/test/fixtures/optimize-const-enums/export-const-enum-babel-7/input.ts b/...ransform-typescript/test/fixtures/optimize-const-enums/export-const-enum-babel-7/input.ts
@@ -0,0 +1,3 @@
+export const enum A { y }
+
+let x = A.y;
diff --git a/...form-typescript/test/fixtures/optimize-const-enums/export-const-enum-babel-7/options.json b/...form-typescript/test/fixtures/optimize-const-enums/export-const-enum-babel-7/options.json
@@ -0,0 +1,3 @@
+{
+	"BABEL_8_BREAKING": false
+}
diff --git a/...nsform-typescript/test/fixtures/optimize-const-enums/export-const-enum-babel-7/output.mjs b/...nsform-typescript/test/fixtures/optimize-const-enums/export-const-enum-babel-7/output.mjs
@@ -0,0 +1,4 @@
+export var A = {
+  y: 0
+};
+let x = A.y;
diff --git a/...ript/test/fixtures/optimize-const-enums/export-const-enum-type-and-value-babel-7/input.ts b/...ript/test/fixtures/optimize-const-enums/export-const-enum-type-and-value-babel-7/input.ts
@@ -0,0 +1,9 @@
+const enum WhitespaceFlag {
+  before = 1 << 0,
+  after = 1 << 1,
+}
+
+export type { WhitespaceFlag as WF1 };
+export { WhitespaceFlag as WF2 };
+
+export const before = WhitespaceFlag.before;
diff --git a/.../test/fixtures/optimize-const-enums/export-const-enum-type-and-value-babel-7/options.json b/.../test/fixtures/optimize-const-enums/export-const-enum-type-and-value-babel-7/options.json
@@ -0,0 +1,6 @@
+{
+  "plugins": [["transform-typescript", { "optimizeConstEnums": true }]],
+  "sourceType": "module",
+  "validateLogs": true,
+  "BABEL_8_BREAKING": false
+}
diff --git a/...pt/test/fixtures/optimize-const-enums/export-const-enum-type-and-value-babel-7/output.mjs b/...pt/test/fixtures/optimize-const-enums/export-const-enum-type-and-value-babel-7/output.mjs
@@ -0,0 +1,6 @@
+var WhitespaceFlag = {
+  before: 1,
+  after: 2
+};
+export { WhitespaceFlag as WF2 };
+export const before = WhitespaceFlag.before;
diff --git a/...pescript/test/fixtures/optimize-const-enums/export-const-enum-type-and-value/options.json b/...pescript/test/fixtures/optimize-const-enums/export-const-enum-type-and-value/options.json
@@ -1,5 +1,6 @@
 {
   "plugins": [["transform-typescript", { "optimizeConstEnums": true }]],
   "sourceType": "module",
-  "validateLogs": true
+  "validateLogs": true,
+  "BABEL_8_BREAKING": true
 }
diff --git a/...typescript/test/fixtures/optimize-const-enums/export-const-enum-type-and-value/output.mjs b/...typescript/test/fixtures/optimize-const-enums/export-const-enum-type-and-value/output.mjs
@@ -1,4 +1,4 @@
-var WhitespaceFlag = {
+const WhitespaceFlag = {
   before: 1,
   after: 2
 };

diff --git a/...in-transform-typescript/test/fixtures/optimize-const-enums/export-const-enum/options.json b/...in-transform-typescript/test/fixtures/optimize-const-enums/export-const-enum/options.json
@@ -0,0 +1,3 @@
+{
+	"BABEL_8_BREAKING": true
+}
diff --git a/...ugin-transform-typescript/test/fixtures/optimize-const-enums/export-const-enum/output.mjs b/...ugin-transform-typescript/test/fixtures/optimize-const-enums/export-const-enum/output.mjs
@@ -1,4 +1,4 @@
-export var A = {
+export const A = {
   y: 0
 };
 let x = A.y;
diff --git a/...-plugin-transform-typescript/test/fixtures/optimize-const-enums/exported-babel-7/input.ts b/...-plugin-transform-typescript/test/fixtures/optimize-const-enums/exported-babel-7/input.ts
@@ -0,0 +1,5 @@
+const enum A { y }
+
+let x = A.y;
+
+export { A };
diff --git a/...gin-transform-typescript/test/fixtures/optimize-const-enums/exported-babel-7/options.json b/...gin-transform-typescript/test/fixtures/optimize-const-enums/exported-babel-7/options.json
@@ -0,0 +1,6 @@
+{
+  "plugins": [["transform-typescript", { "optimizeConstEnums": true }]],
+  "sourceType": "module",
+  "validateLogs": true,
+  "BABEL_8_BREAKING": false
+}
diff --git a/...lugin-transform-typescript/test/fixtures/optimize-const-enums/exported-babel-7/output.mjs b/...lugin-transform-typescript/test/fixtures/optimize-const-enums/exported-babel-7/output.mjs
@@ -0,0 +1,5 @@
+var A = {
+  y: 0
+};
+let x = A.y;
+export { A };
diff --git a/...abel-plugin-transform-typescript/test/fixtures/optimize-const-enums/exported/options.json b/...abel-plugin-transform-typescript/test/fixtures/optimize-const-enums/exported/options.json
@@ -0,0 +1,6 @@
+{
+  "plugins": [["transform-typescript", { "optimizeConstEnums": true }]],
+  "sourceType": "module",
+  "validateLogs": true,
+  "BABEL_8_BREAKING": true
+}
diff --git a/.../babel-plugin-transform-typescript/test/fixtures/optimize-const-enums/exported/output.mjs b/.../babel-plugin-transform-typescript/test/fixtures/optimize-const-enums/exported/output.mjs
@@ -1,4 +1,4 @@
-var A = {
+const A = {
   y: 0
 };
 let x = A.y;

diff --git a/...-transform-typescript/test/fixtures/optimize-const-enums/merged-exported-babel-7/input.ts b/...-transform-typescript/test/fixtures/optimize-const-enums/merged-exported-babel-7/input.ts
@@ -0,0 +1,13 @@
+export const enum A {
+  x, y
+}
+
+export const enum A {
+  z
+}
+
+A.x;
+A["y"];
+A.z;
+A.w;
+A;
diff --git a/...nsform-typescript/test/fixtures/optimize-const-enums/merged-exported-babel-7/options.json b/...nsform-typescript/test/fixtures/optimize-const-enums/merged-exported-babel-7/options.json
@@ -0,0 +1,6 @@
+{
+  "plugins": [["transform-typescript", { "optimizeConstEnums": true }]],
+  "sourceType": "module",
+  "validateLogs": true,
+  "BABEL_8_BREAKING": false
+}
diff --git a/...ransform-typescript/test/fixtures/optimize-const-enums/merged-exported-babel-7/output.mjs b/...ransform-typescript/test/fixtures/optimize-const-enums/merged-exported-babel-7/output.mjs
@@ -0,0 +1,12 @@
+export var A = {
+  x: 0,
+  y: 1
+};
+Object.assign(A, {
+  z: 0
+});
+A.x;
+A["y"];
+A.z;
+A.w;
+A;
diff --git a/...ugin-transform-typescript/test/fixtures/optimize-const-enums/merged-exported/options.json b/...ugin-transform-typescript/test/fixtures/optimize-const-enums/merged-exported/options.json
@@ -0,0 +1,6 @@
+{
+  "plugins": [["transform-typescript", { "optimizeConstEnums": true }]],
+  "sourceType": "module",
+  "validateLogs": true,
+  "BABEL_8_BREAKING": true
+}
diff --git a/...plugin-transform-typescript/test/fixtures/optimize-const-enums/merged-exported/output.mjs b/...plugin-transform-typescript/test/fixtures/optimize-const-enums/merged-exported/output.mjs
@@ -1,4 +1,4 @@
-export var A = {
+export const A = {
   x: 0,
   y: 1
 };