Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information to describe message. #17

Closed
borkdude opened this issue Jun 2, 2020 · 2 comments
Closed

Add information to describe message. #17

borkdude opened this issue Jun 2, 2020 · 2 comments

Comments

@borkdude
Copy link
Contributor

borkdude commented Jun 2, 2020

See nrepl/nrepl#181 (comment)

For babashka we should add to describe:

{:versions {:babashka "0.1.0"
            :babashka.nrepl "0.0.4"}}
@borkdude
Copy link
Contributor Author

@retrogradeorbit This information is added to the describe message so CIDER knows that to expect from the runtime. How should we do this for bootleg, which is similar, but not the same as babashka, but also runs a babashka.nrepl server?

@bbatsov Given that the babashka-ish CLIs are probably limited in amount, maybe for bootleg it would be ok to do:

{:versions {:bootleg "0.1.0"
            :babashka.nrepl "0.0.4"}}

so you can add a case switch for babashka, bootleg, etc?

@bbatsov
Copy link

bbatsov commented Jun 12, 2020

Yeah, that's fine.

borkdude added a commit that referenced this issue Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants