Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added moonlight theme #24

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Brettm12345
Copy link

Hey I made a custom theme to match this https://github.com/atomiks/moonlight-vscode-theme

help
search-hints
firefox-tabs

@b0o b0o self-requested a review March 11, 2020 07:10
@b0o
Copy link
Owner

b0o commented Mar 11, 2020

Thank you @Brettm12345! I like the idea of integrating themes into this project. I haven't had a chance to look closely into this yet; I will review it when I have some spare time. Some things I'll check for:

  • theme can be enabled/disabled by the user at build time
  • documentation has been updated to reflect changes
  • JS code satisfies eslint
  • code is structured so as to be extensible with additional themes in the future

@Brettm12345
Copy link
Author

Brettm12345 commented Mar 12, 2020

The theme itself is contained here it's written in stylus-lang which just compiles to css. It currently uses a shell command inside gulp to build but I feel like we can handle that better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants