Limit boundary list by contributor's selected utility #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstone121
approved these changes
Oct 24, 2022
There was a problem hiding this comment.
Looks good! Working well.
One thing I noticed is that the utilities are not added to the request if it happens before the auth check completes (or at least I think that's what's happening):
Screen.Recording.2022-10-24.at.9.10.42.AM.mov
I'm still going to approve this PR because that seems like an out-of-scope issue. I'll create an issue for it.
|
Thanks for the review and the follow-up issue. I agree that it relates to #78 and will be useful 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Limit the boundary list to just those pertaining to the contributor's selected utility.
Closes #133
Demo
toggle-utility.mp4
Testing Instructions
Checklist
fixup!commits have been squashedCHANGELOG.mdupdated with summary of features or fixes, following Keep a Changelog guidelinesREADME.mdupdated if necessary to reflect the changes