Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize Django module for one-off management commands #1

Closed
wants to merge 14 commits into from
Closed

Initialize Django module for one-off management commands #1

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7a7d1ab
Scaffold Python package and move over source code
Feb 27, 2019
3dd7116
Add PR template and test artifacts
Feb 27, 2019
a35b00e
Adjust ecsmanage command to read configuration values
Feb 27, 2019
dbe4a70
Get ecsmanage command working
Feb 28, 2019
159e654
Make management command installable
Feb 28, 2019
a46dc8d
Initialize tests
Feb 28, 2019
b2e542c
Draft simple README
Feb 28, 2019
4096b3f
Add Travis config and drop support for py2.7 + py3.5
Feb 28, 2019
f42609d
Clean up Travis config
Feb 28, 2019
f929023
Document workarounds in .travis.yml
jeancochrane Mar 2, 2019
80c3ba5
Clean up README
jeancochrane Mar 2, 2019
0aff8d3
Specify Python 3.6+ support
jeancochrane Mar 2, 2019
6c031a8
Use AWS region name for Boto3 clients
jeancochrane Mar 2, 2019
cc8ecbb
Update setup.py to reflect Python 3.6+ requirement
jeancochrane Mar 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Specify Python 3.6+ support 
Make sure the README documents the proper Python support.
  • Loading branch information
@jeancochrane
jeancochrane authored Mar 2, 2019
commit 0aff8d34bf496a7a30ca6b4cd11c5980fde839d2
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ the appropriate AWS resources for your cluster:
## Developing

Local development is managed with Python virtual environments. Make sure that
you have [Python 3.4+ and pip installed](https://www.python.org/downloads/)
you have [Python 3.6+ and pip installed](https://www.python.org/downloads/)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of the use of f-strings in the module, support is limited to Python 3.6+. I couldn't decide how much of a downside this presented.

If we decide to support current Python 3 versions (3.4+), we'll need to refactor ecsmanage/management/commands/ecsmanage.py to remove the use of f-strings. If we decide to support Python 2.7 as well (which will be retired next January), we'll also need to refactor the development environment to not use the standard library virtualenv implementation, which was introduced in Python 3.4.

before starting.

Install the development package in a virtual environment:
Expand Down