-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor azalea-protocol #190
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I realized I should probably merge this sooner rather than later since it fixes a lot, so I downgraded it to 1.21.3 and merged it for that instead of waiting for 1.21.4 to release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some things in azalea-protocol that have been bothering me for a while:
declare_state_packets
macro (notably, packet ids are implicit now)serverbound_keep_alive_packet
tos_keep_alive
configuration
andhandshaking
toconfig
andhandshake
azalea_protocol::packets::game::ClientboundKeepAlive
ItemSlot
toItemStack
for consistency with Mojmap.get()
with.into_variant()
from a newPacket
trait, which is used to avoid most uses of that function now.read_from
/write_into
toazalea_read
/azalea_write
andMcBufReadable
/McBufWritable
toAzaleaRead
/AzaleaWrite
McBuf
toAzBuf
#[limit(number)]
so strings can be limited to a certain size.Based on the 1.21.4 PR since it's probably going to be merged in a few days anyways (diff). Also, these changes were mostly done with a lot of find-and-replace, so I may have messed up in some places without realizing. Please let me know if you notice something I broke or if you disagree with a change.
Some changes were inspired by @EightFactorial's FrogLight project <3
Closes #173