Default disable "Use camelCase" (digital-asset#2885)

axman6 · Sep 11, 2019 · 388af4c · 388af4c
1 parent 41aa03c
commit 388af4c
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 12 deletions.
diff --git a/compiler/damlc/daml-ide-core/dlint.yaml b/compiler/damlc/daml-ide-core/dlint.yaml
@@ -980,8 +980,11 @@
 # --
 # DAML specific
 
+# Not popular or useful
+- ignore: {name: Use camelCase}
+# Not relevant to DAML
 - ignore: {name: Use newtype instead of data}
-
+# Bracketing rules
 - ignore: {name: Redundant bracket}
 - ignore: {name: Redundant $}
 - ignore: {name: Move brackets to avoid $}
diff --git a/compiler/damlc/tests/src/DA/Test/ShakeIdeClient.hs b/compiler/damlc/tests/src/DA/Test/ShakeIdeClient.hs
@@ -279,17 +279,18 @@ dlintSmokeTests mbScenarioService = Tasty.testGroup "Dlint smoke tests"
             setFilesOfInterest [foo]
             expectNoErrors
             expectDiagnostic DsInfo (foo, 2, 0) "Warning: Use fewer imports"
-    ,  testCase' "Suggest use camelCase" $ do
-            foo <- makeFile "Foo.daml" $ T.unlines
-                [ "daml 1.2"
-                , "module Foo where"
-                , "my_fact (n : Int) : Int"
-                , "  | n <= 1    = 1"
-                , "  | otherwise = n * my_fact (n - 1)"
-                ]
-            setFilesOfInterest [foo]
-            expectNoErrors
-            expectDiagnostic DsInfo (foo, 2, 0) "Suggestion: Use camelCase"
+    -- Now disabled by default.
+    -- ,  testCase' "Suggest use camelCase" $ do
+    --         foo <- makeFile "Foo.daml" $ T.unlines
+    --             [ "daml 1.2"
+    --             , "module Foo where"
+    --             , "my_fact (n : Int) : Int"
+    --             , "  | n <= 1    = 1"
+    --             , "  | otherwise = n * my_fact (n - 1)"
+    --             ]
+    --         setFilesOfInterest [foo]
+    --         expectNoErrors
+    --         expectDiagnostic DsInfo (foo, 2, 0) "Suggestion: Use camelCase"
     ,  testCase' "Suggest reduce duplication" $ do
             foo <- makeFile "Foo.daml" $ T.unlines
                 [ "daml 1.2"