Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project status: What target platforms should Axios support and which version of ECMA should be used for PRs and code refactors? #4543

Closed
DigitalBrainJS opened this issue Mar 21, 2022 · 0 comments

Comments

@DigitalBrainJS
Copy link
Collaborator

Describe the issue

We need to clarify in the Contribution guide which ECMA version and target platforms should be supported, otherwise, we are doomed to have a lot of rudimentary code and inconsistencies.
Axios is written in a mix of ES3 and ES5 ECMA versions and it currently claims support for IE11 and newer platforms, but recent PRs use ES5+ features that are not supported by IE without any built-in polyfills. For example, we have trim util that has been deprecated since IE10, while we have Array.prototype.includes that IE doesn't support.

Example Code

N/A

Expected behavior, if applicable

N/A

Environment

N/A

Additional context/Screenshots

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants