Skip to content

Commit

Permalink
fix(adapter): fix undefined reference to hasBrowserEnv (#6572)
Browse files Browse the repository at this point in the history
  • Loading branch information
antoninbas authored Aug 23, 2024
1 parent fed1a4b commit 7004707
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion lib/adapters/http.js
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ export default isHttpAdapterSupported && function httpAdapter(config) {

// Parse url
const fullPath = buildFullPath(config.baseURL, config.url);
const parsed = new URL(fullPath, utils.hasBrowserEnv ? platform.origin : undefined);
const parsed = new URL(fullPath, platform.hasBrowserEnv ? platform.origin : undefined);
const protocol = parsed.protocol || supportedProtocols[0];

if (protocol === 'data:') {
Expand Down
10 changes: 5 additions & 5 deletions test/unit/regression/SNYK-JS-AXIOS-7361793.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import axios from '../../../index.js';
import http from 'http';
import assert from 'assert';
import utils from '../../../lib/utils.js';
import platform from '../../../lib/platform/index.js';


Expand Down Expand Up @@ -52,17 +51,18 @@ describe('Server-Side Request Forgery (SSRF)', () => {
let hasBrowserEnv, origin;

before(() => {
hasBrowserEnv = utils.hasBrowserEnv;
assert.ok(platform.hasBrowserEnv !== undefined);
hasBrowserEnv = platform.hasBrowserEnv;
origin = platform.origin;
utils.hasBrowserEnv = true;
platform.hasBrowserEnv = true;
platform.origin = 'http://localhost:' + String(GOOD_PORT);
});
after(() => {
utils.hasBrowserEnv = hasBrowserEnv;
platform.hasBrowserEnv = hasBrowserEnv;
platform.origin = origin;
});
it('should fetch in client-side mode', async () => {
utils.hasBrowserEnv = true;
platform.hasBrowserEnv = true;
const ssrfAxios = axios.create({
baseURL: 'http://localhost:' + String(GOOD_PORT),
});
Expand Down

0 comments on commit 7004707

Please sign in to comment.