Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logger): PowertoolsLogFormatter docstring and variable naming update #1585

Merged
merged 13 commits into from
Jul 7, 2023
Merged

fix(logger): PowertoolsLogFormatter docstring and variable naming update #1585

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8c5d9c9
Updated formatAttributes for additional parameters and LogItem return…
erikayao93 Jun 15, 2023
9cbfd54
Updated the unit tests to pass with new formatter
erikayao93 Jun 16, 2023
30ad387
Updated Powertool named objects to Powertools
erikayao93 Jun 16, 2023
d1b01b7
Updated tests to match new naming consistency
erikayao93 Jun 16, 2023
256132d
Updated for tests for new naming consistency
erikayao93 Jun 16, 2023
dfb5010
Merge branch 'aws-powertools:main' into formatter-update-test
erikayao93 Jun 16, 2023
51c5f46
Updated formatter for new design decisions
erikayao93 Jun 16, 2023
f9c937f
Update Logger for ephemeral attributes
erikayao93 Jun 19, 2023
a81abb5
Update bringYourOwnFormatter documentation to match new formatter
erikayao93 Jun 19, 2023
b027949
Merge branch 'aws-powertools:main' into formatter-update-test
erikayao93 Jun 30, 2023
2527914
Fixed incorrect return type, renamed variable for consistency
erikayao93 Jul 5, 2023
e044871
Merge branch 'aws-powertools:main' into formatter-update-test
erikayao93 Jul 5, 2023
a42c608
Merge branch 'feat/v2' into formatter-update-test
erikayao93 Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/logger/src/formatter/PowertoolsLogFormatter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class PowertoolsLogFormatter extends LogFormatter {
*
* @param {UnformattedAttributes} attributes
* @param {LogAttributes} additionalLogAttributes
* @returns {PowertoolsLog}
* @returns {LogItem}
*/
public formatAttributes(
attributes: UnformattedAttributes,
Expand All @@ -36,11 +36,11 @@ class PowertoolsLogFormatter extends LogFormatter {
xray_trace_id: attributes.xRayTraceId,
};

const powertoolLogItem = new LogItem({ attributes: baseAttributes });
const powertoolsLogItem = new LogItem({ attributes: baseAttributes });

powertoolLogItem.addAttributes(additionalLogAttributes);
powertoolsLogItem.addAttributes(additionalLogAttributes);

return powertoolLogItem;
return powertoolsLogItem;
}
}

Expand Down