Convert aws-amplify-vue to Typescript #4154
Conversation
|
This pull request fixes 1 alert when merging 6a43f87 into 9a1055a - view on LGTM.com fixed alerts:
|
netroy
force-pushed
the
aws-amplify-vue-ts
branch
from
7c1dab6 to
93bb3f4
Compare
netroy
force-pushed
the
aws-amplify-vue-ts
branch
from
fc4c4b6 to
82ac565
Compare
|
not sure why the tests are getting stuck on the CI. |
netroy
force-pushed
the
aws-amplify-vue-ts
branch
from
82ac565 to
ef0084e
Compare
|
This pull request fixes 1 alert when merging ef0084e into 9a1055a - view on LGTM.com fixed alerts:
|
netroy
force-pushed
the
aws-amplify-vue-ts
branch
from
ef0084e to
2362dcf
Compare
|
This pull request fixes 1 alert when merging 2362dcf into e6f1bb3 - view on LGTM.com fixed alerts:
|
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
#1004
#3499
Description of changes:
Converts the code base for
aws-amplify-vuefrom JavaScript to TypeScript.This cannot generate the declaration files yet, because of this issue in vue-cli.
For declaration file generation, I'd highly recommend switching over from
vue-cli-serviceto plain old webpack.That might also reduce the bundle size, since
vue-cli-serviceadds a bunch of unnecessary stuff to the generated bundles.Also, all vue & vue-cli packages have been marked as
nohoistbecause of this issue in vue-cliBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.