Upgrade to smithy 1.25.0 #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update paginators code generation - Use the member shape to check pointability instead of the target shape for passing the limit from the options to the params. Fix GoPointableIndex bugs - `isMemberDereferencable()` previously used the `isShapeDereferencable()` method, but now is switched to check the that it is NOT in the `INHERENTLY_NONDEREFERENCABLE` set. - `isMemberPointable()` used to incorrectly categorize pointability due to an incorrect condition using `NullableIndex::isNullable()` method, but is now using a new conditionals and the updated `NullableIndex::isMemberNullable()` method with the `CLIENT_ZERO_VALUE_V1_NO_INPUT` check mode. Chores: - Add mavenLocal to codegen build file
syall
force-pushed
the
nullability-fix
branch
from
6fac98d to
b83b55f
Compare
jasdel
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on Smithy 1.25.0 release, BLOCK merging until then.
Issue #, if available:
N/A
Description of changes:
Note: This change introduces break/fix's for pointable types.
Update paginators code generation
Fix GoPointableIndex bugs
isMemberDereferencable()previously used theisShapeDereferencable()method, but now is switched to check the that it is NOT in theINHERENTLY_NONDEREFERENCABLEset.isMemberPointable()used to incorrectly categorize pointability due to an incorrect condition usingNullableIndex::isNullable()method, but is now using a new conditionals and the updatedNullableIndex::isMemberNullable()method with theCLIENT_ZERO_VALUE_V1_NO_INPUTcheck mode.Chores:
Testing:
./gradlew clean build publishToMavenLocal smithy-cli:runtimemake smithy-clean smithy-build smithy-publish-local smithy-cleanmake generateandmake unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.