Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: --base-dir is disregarded in sam build #2718

Merged
merged 6 commits into from
Mar 16, 2021
+315 −38
Merged

fix: --base-dir is disregarded in sam build #2718

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
02b3ae8
fix: build_dir is disregarded in sam build
aahung Mar 16, 2021
a32bda3
fix unit tests
aahung Mar 16, 2021
ad9a1ca
Add debug log
aahung Mar 16, 2021
3992f8e
Add more comments
aahung Mar 16, 2021
ea648fe
Add integ test
aahung Mar 16, 2021
2e73128
Add integ test for docker context
aahung Mar 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add more comments
  • Loading branch information
@aahung
aahung committed Mar 16, 2021
commit 3992f8e4195c989a2c2c488ff223badb4b6a0cb2
3 changes: 3 additions & 0 deletions samcli/commands/build/build_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,9 @@ def __enter__(self) -> "BuildContext":
"\n".join([f"- {full_path}" for full_path in remote_stack_full_paths]),
)

# Note(xinhol): self._use_raw_codeuri is added temporarily to fix issue #2717
# when base_dir is provided, codeuri should not be resolved based on template file path.
# we will refactor to make all path resolution inside providers intead of in multiple places
self._function_provider = SamFunctionProvider(self.stacks, self._use_raw_codeuri)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a note here too and reference the issue number.

self._layer_provider = SamLayerProvider(self.stacks, self._use_raw_codeuri)

Expand Down