refactor: Use dataclasses to make type safer #2391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoffa
changed the title
hoffa
reviewed
Nov 19, 2020
Comment on lines
+115
to
+125
| templates = [ | ||
| TemplateOption( | ||
| obj.get("directory", None), | ||
| obj.get("displayName", None), | ||
| obj.get("dependencyManager", None), | ||
| obj.get("appTemplate", None), | ||
| obj.get("initLocation", None), | ||
| obj.get("isDynamicTemplate", None), | ||
| ) | ||
| for obj in raw_templates | ||
| ] |
There was a problem hiding this comment.
Copying to a typed object feels weird and wasteful; can we use TypedDicts instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Why is this change necessary?
This was originally a part of #2385
With the intro of the following dataclass, mypy can typecheck them so we won't mis-spell dict keys.
TemplateOptionRuntimeDepInfoHow does it address the issue?
What side effects does this change have?
Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.