Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special characters in environment variables are not escaped #319

Closed
arunvelsriram opened this issue Mar 3, 2018 · 1 comment
Closed

Comments

@arunvelsriram
Copy link

Hi,

Here is my template.yaml:

...
Runtime: go1.x
  Tracing: Active
   Environment:
     Variables:
       HANGOUTS_WEBHOOK_URL: "https://api.test.com/v1/contacts/AAAAlmeAGQ0/messages?key=hello-world"
...

It contains an environment variable with = in its value. I used os.Getenv() in my lambda function to read the environment variable.

When invoked locally with sam, = is not escaped the valued read is https://chat.googleapis.com/v1/spaces/AAAAlmeAGQ0/messages?key.

When I run the generated binary directly os.Getenv() seem to read the value correctly as https://api.test.com/v1/contacts/AAAAlmeAGQ0/messages?key=hello-world.

This issue is mentioned in a comment here.

Looks like a bug in sam though am not sure. If this is a bug let me know I will try to fix and raise a PR.

@jfuss
Copy link
Contributor

jfuss commented Jul 2, 2018

This looks like a duplicate of #303, which was resolved with the release of v0.3.0.

Closing

@jfuss jfuss closed this as completed Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants