Fix python tests for upstream PR 128036 #2080
Merged
+0
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2080 +/- ##
==========================================
+ Coverage 78.75% 78.76% +0.01%
==========================================
Files 598 598
Lines 103650 103650
Branches 14719 14719
==========================================
+ Hits 81625 81638 +13
+ Misses 21371 21359 -12
+ Partials 654 653 -1 ☔ View full report in Codecov by Sentry. |
nebeid
approved these changes
Dec 24, 2024
samuel40791765
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
n/a
Description of changes:
Upstream PR 128036 added a new
ssl.HAS_PHAboolean property and allows CPython's tests to account for lack of post-handshake authentication support. This allows us to delete relevant patch sets.Call-outs:
n/a
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.