Remove ENABLE_DILITHIUM flag #2070
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternative option is that we place the three APIs in a new file within https://github.com/aws/aws-lc/tree/main/include/openssl/experimental. Open to thoughts from the team. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2070 +/- ##
==========================================
+ Coverage 78.76% 78.92% +0.15%
==========================================
Files 598 610 +12
Lines 103747 105266 +1519
Branches 14735 14921 +186
==========================================
+ Hits 81718 83076 +1358
- Misses 21375 21539 +164
+ Partials 654 651 -3 ☔ View full report in Codecov by Sentry. |
|
will merge #2072 first to split this PR into smaller sized additions |
|
Seems to be multiple definitions of |
|
cleaning up and splitting PR. new PR is #2082 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
It's time. (also we need to do this to add ML-DSA to the FIPS module)
Description of changes:
enable_dilithiumflagEVP_PKEY_pqdsa_new_raw_private_keytoEVP_PKEY_pqdsa_new_raw_secret_keyto better match the equivalent API for KEMs (EVP_PKEY_kem_new_raw_secret_key).Call-outs:
Removing the flag has little consequence -- other than it makes the APIs we expose in
include/openssl/evp.hthat much more "final". We should consider how much we like them before we commit to them. We made a point to refer to asymmetric keypairs as public and private keys, rather than public and secret keys. However, we haven't always been consistant with this, so there is a mix of both in the library. Users will find the consistency betweenEVP_PKEY_pqdsa_new_raw_secret_keyandEVP_PKEY_kem_new_raw_secret_keymore satisfying.Once we are happy with the name, including the decision around
PQDSA, then we can remove the experimental flags. Personally, I'd advocate for NISTDSA as all NIST signature schemes are matching these API conventions (sign, pre-hash-sign, context-sign -- see ed25519, ML-DSA, SLH-DSA, FN-DSA as examples). Most of this naming is internal, with the exception of the three external functions:EVP_PKEY_CTX_pqdsa_set_params,EVP_PKEY_pqdsa_new_raw_secret_key,EVP_PKEY_pqdsa_new_raw_public_key.Testing:
To celebrate the removal of this flag, enjoy this haiku:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.