[DRAFT] Add ACVP test framework for ML-DSA #2068
Draft
+385
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
reviewed
Dec 18, 2024
| "revision": "FIPS204", | ||
| "parameterSets": ["ML-DSA-44", "ML-DSA-65", "ML-DSA-87"], | ||
| "deterministic": [false], | ||
| "messageLength": [{"min": 8, "max": 65536", "increment": 8}] |
There was a problem hiding this comment.
Suggested change
| "messageLength": [{"min": 8, "max": 65536", "increment": 8}] | |
| "messageLength": [{"min": 8, "max": 65536, "increment": 8}] |
There was a problem hiding this comment.
Thank you, good spot -- that's a bug in the standard too, so I'll let the working group know! Addressed in b9ecf31
|
Failing builds are because of |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2068 +/- ##
=======================================
Coverage 78.76% 78.77%
=======================================
Files 598 598
Lines 103703 103703
Branches 14735 14735
=======================================
+ Hits 81685 81689 +4
+ Misses 21364 21362 -2
+ Partials 654 652 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves #CryptoAlg-2819
Description of changes:
Implements:
Call-outs:
Had to make some changes to:
rndaconstTesting:
Confirmed passing ACVP test vector live server
Confirmed passing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.