Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove usage of deprecated templateOptions.transform #5182

Merged
merged 5 commits into from
Nov 28, 2019
Merged

chore: remove usage of deprecated templateOptions.transform #5182

merged 5 commits into from
Nov 28, 2019

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Nov 25, 2019 •
edited
Loading

cfn2ts was still generating code with the deprecated templateOptions.transform.

Remove duplicates from templateOptions.transforms in @aws-cdk/core (avoids multiple
time the same transform when using L1 resources from @aws-cdk/aws-sam).

Update README in @aws-cdk/core.

Was not included in #3395 and leads, among other things, to deprecation warnings
when creating a new RDS Database Instance which uses a serverless application
for the password rotation. This is because the generated code for @aws-cdk/aws-sam was
still using deprecated code.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@jogold
chore: remove usage of deprecated transform
5db8603 
Was not included in aws#3395 and leads, among other things, to deprecation warnings
when creating a new RDS Database Instance which uses a serverless application
for the password rotation.
@jogold jogold requested a review from eladb as a code owner November 25, 2019 14:22
@mergify
Copy link
Contributor

mergify bot commented Nov 25, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@skinny85
Copy link
Contributor

@jogold what are all the changes outside the ReadMe of the package? Can you add some justification for why are they needed? Neither the PR title, nor its description talk about it...

@jogold
Copy link
Contributor Author

jogold commented Nov 25, 2019

@jogold what are all the changes outside the ReadMe of the package?

cfn2ts was generating code with the deprecated transform

@jogold
Copy link
Contributor Author

jogold commented Nov 25, 2019

Neither the PR title, nor its description talk about it...

Updated PR description

@jogold jogold changed the title chore: remove usage of deprecated transform chore: remove usage of deprecated templateOptions.transform Nov 25, 2019
eladb
eladb previously requested changes Nov 26, 2019
View reviewed changes
packages/@aws-cdk/core/lib/stack.ts Outdated
Comment on lines 1115 to 1120
function extractSingleValue<T>(array: T[] | undefined): T[] | T | undefined {
if (array && array.length === 1) {
return array[0];
if (array) {
if (array.length === 1) {
return array[0];
}
return Array.from(new Set(array)); // Unique values
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something about this function is very odd. It says "extract single value" but can return an array. Also, there is no mention of the deduplication.

Maybe we should just remove this function and write this very purpose-built code when synthing the Transform

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. Also how about having a addTransform() method on Stack? Since templateOptions.transforms is writable and is a list since #3395 this would avoid having to do this.stack.templateOptions.transforms = [...this.stack.templateOptions.transforms || [], 'ExtraTransform'] each time...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done already

@mergify mergify bot dismissed eladb’s stale review November 26, 2019 12:41

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Nov 28, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 3780c12 into aws:master Nov 28, 2019
@jogold jogold deleted the deprecated-transform branch January 9, 2020 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees

@eladb eladb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jogold @aws-cdk-automation @skinny85 @eladb