From 12f0503dabf5f8e9c94afdf19aae7c8ba88b162a Mon Sep 17 00:00:00 2001 From: Michael Hobbs Date: Tue, 4 Jul 2023 14:08:43 -0400 Subject: [PATCH 1/2] Update container-definition.ts Update JSDOC for `user` to make it clear that this is a `user string` and not restricted to a user name. --- packages/aws-cdk-lib/aws-ecs/lib/container-definition.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/aws-cdk-lib/aws-ecs/lib/container-definition.ts b/packages/aws-cdk-lib/aws-ecs/lib/container-definition.ts index ab7a5f88f3ef2..89797bde65509 100644 --- a/packages/aws-cdk-lib/aws-ecs/lib/container-definition.ts +++ b/packages/aws-cdk-lib/aws-ecs/lib/container-definition.ts @@ -294,8 +294,9 @@ export interface ContainerDefinitionOptions { readonly readonlyRootFilesystem?: boolean; /** - * The user name to use inside the container. - * + * The user to use inside the container. This parameter maps to User in the Create a container section of the Docker Remote API and the --user option to docker run. + * + * @see {@link https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task_definition_parameters.html#ContainerDefinition-user|ContainerDefinition User} * @default root */ readonly user?: string; From e3762ecb107c0f2361f07ad742359bf21f4c4fcb Mon Sep 17 00:00:00 2001 From: Momo Kornher Date: Wed, 5 Jul 2023 14:06:18 +0100 Subject: [PATCH 2/2] Update packages/aws-cdk-lib/aws-ecs/lib/container-definition.ts --- packages/aws-cdk-lib/aws-ecs/lib/container-definition.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/aws-cdk-lib/aws-ecs/lib/container-definition.ts b/packages/aws-cdk-lib/aws-ecs/lib/container-definition.ts index 89797bde65509..26d64f1e28062 100644 --- a/packages/aws-cdk-lib/aws-ecs/lib/container-definition.ts +++ b/packages/aws-cdk-lib/aws-ecs/lib/container-definition.ts @@ -295,8 +295,8 @@ export interface ContainerDefinitionOptions { /** * The user to use inside the container. This parameter maps to User in the Create a container section of the Docker Remote API and the --user option to docker run. - * - * @see {@link https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task_definition_parameters.html#ContainerDefinition-user|ContainerDefinition User} + * + * @see https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task_definition_parameters.html#ContainerDefinition-user * @default root */ readonly user?: string;