chore: Add note that assets are not account for in diff (#1439)

Fixes #1327 Related to #395
aws · Dec 27, 2018 · 36f69b6 · 36f69b6
1 parent 04217a5
commit 36f69b6
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/packages/aws-cdk/lib/diff.ts b/packages/aws-cdk/lib/diff.ts
@@ -12,6 +12,11 @@ import { print, warning } from './logging';
  * @returns the count of differences that were rendered.
  */
 export function printStackDiff(oldTemplate: any, newTemplate: cxapi.SynthesizedStack, strict: boolean): number {
+  if (_hasAssets(newTemplate)) {
+    const issue = 'https://github.com/awslabs/aws-cdk/issues/395';
+    warning(`The ${newTemplate.name} stack uses assets, which are currently not accounted for in the diff output! See ${issue}`);
+  }
+
   const diff = cfnDiff.diffTemplate(oldTemplate, newTemplate.template);
 
   // filter out 'AWS::CDK::Metadata' resources from the template
@@ -88,3 +93,7 @@ function buildLogicalToPathMap(template: cxapi.SynthesizedStack) {
   }
   return map;
 }
+
+function _hasAssets(stack: cxapi.SynthesizedStack) {
+  return Object.values(stack.metadata).find(entries => entries.find(entry => entry.type === cxapi.ASSET_METADATA) != null) != null;
+}