Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add another app #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add another app #25

wants to merge 1 commit into from

Conversation

fmaussion
Copy link

Thanks!

@MarcSkovMadsen
Copy link
Collaborator

MarcSkovMadsen commented Sep 28, 2020 •
edited
Loading

Hi @fmaussion

Thanks for the contribution.

Regarding the Simulator I was just not sure it was a Panel app as it states its a Bokeh app. Can you confirm its a Panel app?

image

The files you have changed are actually updated from the files application\config\resources.py and application\config\authors.py. The updates I believe I should make are

OGGM_EDU = Author(
    name="OGGM EDU",
    url="https://edu.oggm.org",
    github_url="https://github.com/OGGM",
    github_avatar_url="https://avatars2.githubusercontent.com/u/14758186",
)

and

Resource(
        name="World Glaciers Explorer",
        url="https://edu.oggm.org/en/latest/explorer.html",
        thumbnail_png_path=THUMBNAILS_ROOT + "",
        is_awesome=True,
        tags=[tags.APP, tags.CODE],
        author=authors.OGGM_EDU,
    ),
    Resource(
        name="Glacier Simulator",
        url="https://edu.oggm.org/en/latest/simulator.html",
        thumbnail_png_path=THUMBNAILS_ROOT + "",
        is_awesome=True,
        tags=[tags.APP, tags.CODE],
        author=authors.OGGM_EDU,
    ),

Can you confirm?¨

Thanks again.

@fmaussion
Copy link
Author

Can you confirm its a Panel app?

Yes! We call it "bokeh app" because we serve it on our server which is called https://bokeh.oggm.org -> in the end the engine which runs it all is Bokeh, but we use panel extensively. Here is the app's code: https://github.com/OGGM/glacier_simulator

Can you confirm?¨

Perfect thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmaussion @MarcSkovMadsen