Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lidar_centerpoint): remove build_only param from param.yaml #856

Merged

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Feb 7, 2024

Description

Fix a bug in #822

Tests performed

Not applicable

Effects on system behavior

Not applicable

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda requested a review from knzo25 February 7, 2024 00:49
Copy link
Contributor

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (sorry I missed this on the other PR)

@kminoda kminoda merged commit b191415 into autowarefoundation:main Feb 7, 2024
9 of 10 checks passed
@kminoda kminoda deleted the fix/centerpoint/remove_build_only branch February 7, 2024 01:49
yuki-takagi-66 pushed a commit to tier4/autoware_launch that referenced this pull request Jun 5, 2024
Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
yuki-takagi-66 pushed a commit to tier4/autoware_launch that referenced this pull request Jul 3, 2024
Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants