Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_velocity_planner): update launch and parameter files for plugin #369

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented May 25, 2023

Description

Update launch and parameter files. See autowarefoundation/autoware.universe#3724 for details.
This PR depends on autowarefoundation/autoware.universe#3811.

Tests performed

Check autonomous driving in planning simulator.

Effects on system behavior

None.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi isamu-takagi changed the title Refactor/launch behavior velocity planner refactor(behavior_velocity_planner): update launch and parameter files for plugin May 25, 2023
Copy link
Contributor

@maxime-clem maxime-clem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with autowarefoundation/autoware.universe#3811 and it works well.

soblin referenced this pull request in tier4/autoware_launch May 26, 2023
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (40685b5) 0.00% compared to head (1785c1b) 0.00%.

❗ Current head 1785c1b differs from pull request most recent head 98f2a22. Consider uploading reports for the commit 98f2a22 to get more accurate results

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #369   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isamu-takagi isamu-takagi merged commit c6108a2 into autowarefoundation:main Jun 7, 2023
@isamu-takagi isamu-takagi deleted the refactor/launch-behavior-velocity-planner branch June 7, 2023 12:40
@mehmetdogru
Copy link
Contributor

mehmetdogru commented Jun 7, 2023

@isamu-takagi it seems there are some missing modules in the PR during refactoring. Is there a reason for that?

@isamu-takagi
Copy link
Contributor Author

@mehmetdogru Thank you. It seems that the merge did not work well because the no_drivable_lane module was added during this PR. I'll add it. Are there any other missing modules?

@mehmetdogru
Copy link
Contributor

Under launch modules only no_drivable_lane.

In planning_component.launch.xml there are a few missing:

virtual_traffic_light
occlusion_spot
run_out
speed_bump
no_drivable_lane

Thank you 🙏

@isamu-takagi
Copy link
Contributor Author

Ah, I see. Always load all module parameters and only change launch_modules.

@isamu-takagi
Copy link
Contributor Author

Create PR: #389.

rej55 pushed a commit to rej55/autoware_launch that referenced this pull request Jun 12, 2023
…on#369)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Sep 12, 2023
…stacle-margin-6

feat(autoware_launch): set terminal obstacle stop margin to 6.0
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants