-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(behavior_velocity_planner): update launch and parameter files for plugin #369
refactor(behavior_velocity_planner): update launch and parameter files for plugin #369
Conversation
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with autowarefoundation/autoware.universe#3811 and it works well.
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. |
autoware_launch/launch/components/tier4_planning_component.launch.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@isamu-takagi it seems there are some missing modules in the PR during refactoring. Is there a reason for that? |
@mehmetdogru Thank you. It seems that the merge did not work well because the no_drivable_lane module was added during this PR. I'll add it. Are there any other missing modules? |
Under launch modules only no_drivable_lane. In planning_component.launch.xml there are a few missing: virtual_traffic_light Thank you 🙏 |
Ah, I see. Always load all module parameters and only change |
Create PR: #389. |
…on#369) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…stacle-margin-6 feat(autoware_launch): set terminal obstacle stop margin to 6.0
chore: sync awf-latest
Description
Update launch and parameter files. See autowarefoundation/autoware.universe#3724 for details.
This PR depends on autowarefoundation/autoware.universe#3811.
Tests performed
Check autonomous driving in planning simulator.
Effects on system behavior
None.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.