refactor(behavior_velocity_planner): update launch and parameter files for plugin #3811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
isamu-takagi
requested review from
kosuke55,
kyoichi-sugahara,
mkuri,
soblin,
maxime-clem,
satoshi-ota,
shmpwk,
taikitanaka3,
takayuki5168,
TomohitoAndo,
tkimura4,
purewater0901,
a team,
rej55,
TakaHoribe and
zulfaqar-azmi-t4
as code owners
github-actions
bot
added
component:launch
4 tasks
isamu-takagi
changed the title
maxime-clem
approved these changes
May 25, 2023
There was a problem hiding this comment.
Tested with autowarefoundation/autoware_launch#369 and it works well.
The README of the behavior_velocity_planner needs to be updated (https://github.com/autowarefoundation/autoware.universe/tree/main/planning/behavior_velocity_planner#node-parameters) but this can be done in a separate PR.
...g_launch/launch/scenario_planning/lane_driving/behavior_planning/behavior_planning.launch.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Updated #3864. |
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3811 +/- ##
==========================================
+ Coverage 14.08% 14.39% +0.30%
==========================================
Files 1449 1456 +7
Lines 102310 102483 +173
Branches 27293 29691 +2398
==========================================
+ Hits 14412 14752 +340
+ Misses 72114 71592 -522
- Partials 15784 16139 +355
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update launch and parameter files. See #3724 for details.
This PR depends on autowarefoundation/autoware_launch#369.
Tests performed
Check autonomous driving in planning simulator.
Effects on system behavior
None.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.