fix(behavior_velocity_planner): continue collision checking after pass judge #2859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ollision checking Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
github-actions
bot
added
the
component:planning
Codecov ReportBase: 11.62% // Head: 11.62% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2859 +/- ##
==========================================
- Coverage 11.62% 11.62% -0.01%
==========================================
Files 1321 1321
Lines 92140 92144 +4
Branches 24443 24446 +3
==========================================
Hits 10714 10714
- Misses 70244 70248 +4
Partials 11182 11182
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
requested review from
kosuke55,
kyoichi-sugahara,
mkuri,
satoshi-ota,
shmpwk,
taikitanaka3,
takayuki5168,
TomohitoAndo,
tkimura4,
purewater0901 and
a team
as code owners
7 tasks
takayuki5168
approved these changes
Feb 11, 2023
soblin
added a commit
to soblin/autoware.universe
that referenced
this pull request
May 7, 2023
…s judge (autowarefoundation#2859) * fix(behavior_velocity_planner): check if over pass judge line after collision checking Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * fix(behavior_velocity_planner): revert part of autowarefoundation#2719 Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> --------- Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reverts part of #2719 to continue collision checking after pass judge line.
Related links
parameter PR(awf): autowarefoundation/autoware_launch#203
parameter PR(tier4): https://github.com/tier4/autoware_launch/pull/769
Tests performed
CI result is OK
https://evaluation.tier4.jp/evaluation/reports/f76d27e4-ef8a-5036-ae27-0b2574cbb0d1?project_id=prd_jt
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.