ci(buildkite): bypass drafted dependency builds #7243

nightah · 2024-04-26T05:37:15Z

This updates Buildkite to ignore any dependabot or renovate builds which are marked as drafts.

Summary by CodeRabbit

New Features
- Introduced annotations for draft builds and bypassing CI/CD steps in specific scenarios.
Refactor
- Minor modifications in HTML structure and content for build annotations.
Chore
- Updated pipeline script to conditionally bypass CI/CD steps based on pull request and branch conditions.

authelia · 2024-04-26T05:37:19Z

Artifacts

These changes are published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

docker pull authelia/authelia:ci-draftbypass
docker pull ghcr.io/authelia/authelia:ci-draftbypass

coderabbitai · 2024-04-26T05:37:58Z

Walkthrough

The changes focus on optimizing the CI/CD process by refining dependency management. Updates include minor HTML adjustments in build annotations, a new file for draft builds, and a significant enhancement in the pipeline script with a conditional block to control CI_BYPASS based on specific pull request and branch conditions.

Changes

File	Summary
`.buildkite/annotations/...`	Minor HTML modifications in `artifacts` and `bypass` sections; new `draft` section added.
`.buildkite/hooks/post-command`	Improved script readability by updating variable interpolation and assignments.
`.buildkite/pipeline.sh`	Added conditional block to set `CI_BYPASS` to "true" under specific conditions.

Possibly related issues

github/Dependency Dashboard #2330
- The updates in the .buildkite/pipeline.sh file might help in managing dependencies efficiently and ensuring they are up to date with specific versions, aligning with the objective of updating dependencies in the linked issue.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 2

.buildkite/pipeline.sh

Signed-off-by: Amir Zarrinkafsh <nightah@me.com>

james-d-elliott

LGTM

coderabbitai

Actionable comments posted: 1

coderabbitai · 2024-04-26T07:53:54Z

.buildkite/pipeline.sh

-    if [[ "${BUILDKITE_BRANCH}" == "master" ]]; then
+if [[ ${DIVERGED} == 0 ]]; then
+  if [[ ${BUILDKITE_TAG} == "" ]]; then
+    if [[ ${BUILDKITE_BRANCH} == "master" ]]; then


Consider using modern command substitution syntax for better readability.

- BUILD_DUO=$(git diff --name-only HEAD~1 | grep -q ^internal/suites/example/compose/duo-api/Dockerfile && echo true || echo false) + BUILD_DUO=$(git diff --name-only $(git rev-parse HEAD~1) | grep -q ^internal/suites/example/compose/duo-api/Dockerfile && echo true || echo false)

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

if [[ ${BUILDKITE_BRANCH} == "master" ]]; then

if [[ ${BUILDKITE_BRANCH} == "master" ]]; then

codecov · 2024-04-26T08:07:08Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.73%. Comparing base (ef1e1ee) to head (171cf2b).

❗ Current head 171cf2b differs from pull request most recent head a9e73ad. Consider uploading reports for the commit a9e73ad to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7243      +/-   ##
==========================================
+ Coverage   73.65%   73.73%   +0.07%     
==========================================
  Files         346      346              
  Lines       29986    29986              
  Branches      839      839              
==========================================
+ Hits        22086    22109      +23     
+ Misses       7026     7010      -16     
+ Partials      874      867       -7

Flag	Coverage Δ
backend	`74.61% <ø> (+0.09%)`	⬆️
frontend	`65.97% <ø> (-0.10%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

nightah requested a review from james-d-elliott April 26, 2024 05:37

coderabbitai bot reviewed Apr 26, 2024

View reviewed changes

.buildkite/pipeline.sh Outdated Show resolved Hide resolved

.buildkite/pipeline.sh Outdated Show resolved Hide resolved

nightah force-pushed the ci-draftbypass branch from 269175f to d3e54e3 Compare April 26, 2024 07:47

ci(buildkite): bypass drafted dependency builds

409456a

Signed-off-by: Amir Zarrinkafsh <nightah@me.com>

nightah force-pushed the ci-draftbypass branch from d3e54e3 to 409456a Compare April 26, 2024 07:50

james-d-elliott approved these changes Apr 26, 2024

View reviewed changes

coderabbitai bot reviewed Apr 26, 2024

View reviewed changes

nightah and others added 2 commits April 26, 2024 18:16

Merge branch 'master' into ci-draftbypass

171cf2b

Merge branch 'master' into ci-draftbypass

a9e73ad

james-d-elliott enabled auto-merge (squash) April 26, 2024 10:53

james-d-elliott disabled auto-merge April 26, 2024 10:53

james-d-elliott enabled auto-merge (squash) April 26, 2024 10:53

james-d-elliott added 2 commits April 26, 2024 20:57

Merge branch 'master' into ci-draftbypass

fccf1e8

Merge branch 'master' into ci-draftbypass

036e476

james-d-elliott merged commit 5fe883f into master Apr 26, 2024
43 checks passed

james-d-elliott deleted the ci-draftbypass branch April 26, 2024 11:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci(buildkite): bypass drafted dependency builds #7243

ci(buildkite): bypass drafted dependency builds #7243

nightah commented Apr 26, 2024 •

edited by coderabbitai bot

Loading

authelia bot commented Apr 26, 2024

coderabbitai bot commented Apr 26, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

james-d-elliott left a comment

coderabbitai bot left a comment

coderabbitai bot Apr 26, 2024

codecov bot commented Apr 26, 2024 •

edited

Loading

	if [[ ${BUILDKITE_BRANCH} == "master" ]]; then
	if [[ ${BUILDKITE_BRANCH} == "master" ]]; then

ci(buildkite): bypass drafted dependency builds #7243

ci(buildkite): bypass drafted dependency builds #7243

Conversation

nightah commented Apr 26, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

authelia bot commented Apr 26, 2024

Artifacts

Docker Container

coderabbitai bot commented Apr 26, 2024 • edited Loading

Walkthrough

Changes

Possibly related issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

james-d-elliott left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Apr 26, 2024

Choose a reason for hiding this comment

codecov bot commented Apr 26, 2024 • edited Loading

Codecov Report

nightah commented Apr 26, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 26, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

codecov bot commented Apr 26, 2024 •

edited

Loading