Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(oidc): add preferred username claim #2801

Merged
merged 3 commits into from
Jan 18, 2022
Merged

fix(oidc): add preferred username claim #2801

merged 3 commits into from
Jan 18, 2022

Conversation

james-d-elliott
Copy link
Member

This adds the missing preferred username claim to the ID Token for OIDC.

Fixes #2798

@james-d-elliott
fix(oidc): add preferred username claim
322fd2e 
This adds the missing preferred username claim to the ID Token for OIDC.
@authelia
Copy link

authelia bot commented Jan 15, 2022

Artifacts

These changes are published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

  • docker pull authelia/authelia:fix-oidc-preferred-username
  • docker pull ghcr.io/authelia/authelia:fix-oidc-preferred-username

@codecov
Copy link

codecov bot commented Jan 15, 2022 •
edited
Loading

Codecov Report

Merging #2801 (63b944c) into master (e439189) will increase coverage by 0.02%.
The diff coverage is 90.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2801      +/-   ##
==========================================
+ Coverage   63.99%   64.02%   +0.02%     
==========================================
  Files         215      215              
  Lines       10583    10588       +5     
  Branches      266      266              
==========================================
+ Hits         6773     6779       +6     
- Misses       3313     3318       +5     
+ Partials      497      491       -6
Flag Coverage Δ
backend 67.65% <90.32%> (+0.02%) ⬆️
frontend 41.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/handlers/oidc.go 93.18% <89.65%> (-6.82%) ⬇️
internal/handlers/handler_oidc_authorization.go 55.17% <100.00%> (-1.98%) ⬇️
internal/server/error_handler.go 0.00% <0.00%> (-43.75%) ⬇️
internal/ntp/util.go 88.46% <0.00%> (+11.53%) ⬆️

clems4ever
clems4ever approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@clems4ever clems4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Adding some unit tests could be a good idea, however.

@james-d-elliott james-d-elliott merged commit 06641cd into master Jan 18, 2022
@james-d-elliott james-d-elliott deleted the fix-oidc-preferred-username branch January 18, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clems4ever clems4ever clems4ever approved these changes

@nightah nightah Awaiting requested review from nightah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OIDC claim for preferred username
2 participants
@james-d-elliott @clems4ever