Skip to content

Commit

Permalink
Merge pull request #79 from atomicjolt/sc/docs-fixes
Browse files Browse the repository at this point in the history
docs: fixed doc building & maybe fix building docs on tag push
  • Loading branch information
seanrcollings authored Jan 21, 2025
2 parents e465e36 + 993bafe commit 2412968
Show file tree
Hide file tree
Showing 7 changed files with 2,479 additions and 741 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
name: Deploy Storybook to GitHub Pages
name: Deploy Docs to GitHub Pages

on:
push:
tags: ["*"]
tags:
- "@*"

jobs:
build:
Expand Down
File renamed without changes.
3,194 changes: 2,466 additions & 728 deletions package-lock.json

Large diffs are not rendered by default.

11 changes: 5 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"name": "atomic-packages",
"private": true,
"type": "module",
"workspaces": [
"packages/atomic-elements",
"packages/atomic-fuel",
Expand All @@ -16,7 +15,7 @@
"prepare": "npm run storybook:cssprops",
"playground": "vite --config playground/vite.config.ts dev",
"storybook:dev": "storybook dev -p 6006 ",
"storybook:cssprops": "tsx bin/update-css-props.ts",
"storybook:cssprops": "tsx bin/update-css-props.mts",
"storybook:build": "npm run storybook:cssprops && storybook build -o docs/build/storybook",
"storybook:publish": "npm run storybook:build ${0} && gh-pages -d docs -m ${0}",
"storybook:publish:next": "npm run storybook:build next && gh-pages -d docs/next -m next -e next",
Expand All @@ -31,10 +30,10 @@
},
"dependencies": {
"@changesets/cli": "^2.27.10",
"@docusaurus/core": "^3.6.1",
"@docusaurus/plugin-content-docs": "^3.6.1",
"@docusaurus/preset-classic": "^3.6.1",
"@docusaurus/theme-classic": "^3.6.1",
"@docusaurus/core": "^3.7.0",
"@docusaurus/plugin-content-docs": "^3.7.0",
"@docusaurus/preset-classic": "^3.7.0",
"@docusaurus/theme-classic": "^3.7.0",
"@ljcl/storybook-addon-cssprops": "^4.0.0",
"@storybook/addon-actions": "^8.0.10",
"@storybook/addon-docs": "^8.0.10",
Expand Down
10 changes: 5 additions & 5 deletions packages/atomic-elements/docs/Storybook.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ a complex dev stack, force certain data into your database, or navigate around y

Storybook is organized into components. Each component is made up of documentation and one or more stories.

![Storybook Hiearchy](https://storybook.js.org/056e66376330392b5bcc10deb45814b2/naming-hierarchy-sidebar-anatomy.png)
<img src="/atomic-libs/img/storybook-hiearchy.png" alt="Storybook Hiearchy" />

## Controls

Expand All @@ -24,8 +24,8 @@ Controls are ways that you can interact with your component.
src="/atomic-libs/video/addon-controls-demo-optimized.mp4"
height="600"
width="100%"
loop="true"
autoplay="true"
loop
autoPlay
/>

Reference the [Storybook docs on how to develop controls](https://storybook.js.org/docs/react/essentials/controls)
Expand All @@ -38,8 +38,8 @@ Actions are used to observe data emitted by event handlers in components.
src="/atomic-libs/video/addon-actions-demo-optimized.mp4"
height="600"
width="100%"
loop="true"
autoplay="true"
loop
autoPlay
/>

[Storybook docs on Actions](https://storybook.js.org/docs/react/essentials/actions)
Expand Down
Binary file removed public/img/storybook-controls.png
Binary file not shown.
Binary file added public/img/storybook-hiearchy.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 2412968

Please sign in to comment.