⬆️ electron@6.1.12 #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ps://github.com/atom/atom into electron-6.1.12-bump-electron-packager-from-git
⬆️ find-and-replace@0.219.5
⬆️ settings-view@0.261.5
This comment has been minimized.
This comment has been minimized.
|
@DeeDeeG Could you update this branch from our master and merge it? Try to use upstream changes for Node versions by keeping our templates. |
|
Hi, I did this just recently: https://github.com/DeeDeeG/atom/commits/electron-6-atom-ide-community I think that's what you are looking for. I can push the commits here. Edit: Waiting for CI to pass. Will take a look tomorrow and see how it went, re-run timeouts, etc. |
|
Is this ready? Can we merge? |
|
I'm |
|
I'm getting unlucky with the timeouts today. |
|
Passing CI, woo! Only took four runs... Hope that's not the pattern going forward! Ready to go!!! |
|
Yay! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This updates Electron to 6.1.12.
Ref: atom#21079
Release Notes