Dispose of subscriptions properly when deactivating

atom · Nov 4, 2017 · c353913 · c353913
1 parent 7c0a652
commit c353913
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/lib/main.js b/lib/main.js
@@ -1,13 +1,20 @@
+const {CompositeDisposable} = require('atom')
+
 let TimecopView = null
 const ViewURI = 'atom://timecop'
 
 module.exports = {
   activate () {
-    atom.workspace.addOpener(filePath => {
+    this.subscriptions = new CompositeDisposable()
+    this.subscriptions.add(atom.workspace.addOpener(filePath => {
       if (filePath === ViewURI) return this.createTimecopView({uri: ViewURI})
-    })
+    }))
+
+    this.subscriptions.add(atom.commands.add('atom-workspace', 'timecop:view', () => atom.workspace.open(ViewURI)))
+  },
 
-    atom.commands.add('atom-workspace', 'timecop:view', () => atom.workspace.open(ViewURI))
+  deactivate () {
+    this.subscriptions.dispose()
   },
 
   createTimecopView (state) {