Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Fix some Tree-sitter bugs found when enabling by default #17956

Merged
merged 2 commits into from
Aug 30, 2018
Merged

Fix some Tree-sitter bugs found when enabling by default #17956

merged 2 commits into from
Aug 30, 2018

Conversation

maxbrunsfeld
Copy link
Contributor

This PR extracts two bug fixes that I found as part of #17879:

  • Ensure that grammars' root scope descriptors are always included in scope descriptors, even for buffer positions for which there is no syntax node (i.e. leading or trailing whitespace in the file).
  • Tweak the logic for updating parse trees synchronously for quick parses such that it works when there are synchronous edits and multiple quick parses in a row.

/cc @joefitzgerald - I believe this fixes the bug you reported today

Fixes #17942

@maxbrunsfeld maxbrunsfeld merged commit 09181ac into master Aug 30, 2018
@maxbrunsfeld maxbrunsfeld deleted the mb-tree-sitter-fixes branch August 30, 2018 21:10
maxbrunsfeld pushed a commit that referenced this pull request Aug 30, 2018
@maxbrunsfeld
Merge pull request #17956 from atom/mb-tree-sitter-fixes
c222849 
Fix some Tree-sitter bugs found when enabling by default
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tree-Sitter: Invalid scope detected for empty JavaScript lines
1 participant
@maxbrunsfeld