Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pandas backend support for Table read/write #8381

Merged
merged 9 commits into from
Mar 18, 2019
+272 −6
Merged

Add pandas backend support for Table read/write #8381

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7347526
Add pandas backend for Table read/write
taldcroft Jan 26, 2019
a75a6e0
Add tests of pandas backend
taldcroft Mar 15, 2019
307ff64
Use flavor=bs4 for HTML and add optional html5lib pkg for test
taldcroft Mar 15, 2019
2f80876
Update change log
taldcroft Mar 15, 2019
fed9477
Add docs
taldcroft Mar 15, 2019
5e50006
Fix trailing whitespace that is failing flake8
taldcroft Mar 15, 2019
35365a8
Allow compatibility with pandas back to 0.14
taldcroft Mar 16, 2019
3fd90c8
Fix test/doc issues related to optional dependencies
taldcroft Mar 17, 2019
4388d89
Update astropy/io/misc/pandas/connect.py
pllim Mar 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use flavor=bs4 for HTML and add optional html5lib pkg for test
  • Loading branch information
@taldcroft
taldcroft committed Mar 15, 2019
commit 307ff643fbc3c6a1088fe74c3f4d6ce631c7e234
4 changes: 2 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ env:
- PYTEST_VERSION=3.10
- MAIN_CMD='python setup.py'
- CONDA_DEPENDENCIES='Cython jinja2'
- CONDA_ALL_DEPENDENCIES='Cython jinja2 scipy h5py matplotlib pyyaml pandas pytz beautifulsoup4 ipython mpmath bleach bottleneck'
- DEV_PIP_DEP='asdf>=2.3 Cython jinja2 scipy h5py matplotlib pyyaml scikit-image pandas pytz beautifulsoup4 ipython mpmath bleach bottleneck'
- CONDA_ALL_DEPENDENCIES='Cython jinja2 scipy h5py matplotlib pyyaml pandas pytz html5lib beautifulsoup4 ipython mpmath bleach bottleneck'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we need to list html5lib as optional dependency in docs/install.rst, and while editing that file, please mention that 0.14 is the minimum pandas version required.

- DEV_PIP_DEP='asdf>=2.3 Cython jinja2 scipy h5py matplotlib pyyaml scikit-image pandas pytz html5lib beautifulsoup4 ipython mpmath bleach bottleneck'
- ASDF_PIP_DEP='asdf>=2.3'
- SETUP_XVFB=True
- EVENT_TYPE='push pull_request'
Expand Down
2 changes: 1 addition & 1 deletion astropy/io/misc/pandas/connect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
PANDAS_FMTS = {'csv': {'read': {},
'write': {'index': False}},
'fwf': {'read': {}}, # No writer
'html': {'read': {},
'html': {'read': {'flavor': 'bs4'},
'write': {'index': False}},
'json': {'read': {'orient': 'columns'},
'write': {'orient': 'columns', 'index': True}}}
Expand Down