(deps) Upgrade Angular to 13.0.2 #1070
Conversation
|
@satanTime would you be able to help and figure out why most test don't work anymore after trying to upgrade Angular from 12 to 13? The app runs fine (all Cypress tests are green) so it must be a configuration setting. The issue is with ngrx store, I believe, because every time I do this in a test: import { MockStore } from "@ngrx/store/testing";
const store: MockStore = TestBed.inject(MockStore);I get the following error: ( Thank you in advance! |
|
Hi @siovene, I hope you are doing great. I think it belongs to changes in angular 13.0.3. Currently I'm investigating that, but looks like there is not an easy fix, and I need some time to publish a proper on. Hopefully asap. Please check that issue on GitHub: help-me-mom/ng-mocks#1427, maybe its comments'd help until the fix is here. |
|
@satanTime ok thanks, I'll wait for that fix. Thank you very much! |
But this PR is for 13.0.2. I'm reading on the issue page in your repo that you recommend staying with 13.0.2 until you can release a fix, but I'm not trying to upgrade above 13.0.2. I'm trying from 12 to 13.0.2. Any other comments? Thank you very much! |
|
Hi @siovene, You are right. With <=13.0.2, I expect that the latest ng-mocks will work. If it still fails here, I'll take a deeper look at the upcoming weekend. |
# Conflicts: # angular.json # package-lock.json
|
@satanTime just FYI, I don't think this problem is related to help-me-mom/ng-mocks#1427. Could you take a look when you have time? I understand that I will need to wait after you've addressed help-me-mom/ng-mocks#1427, no problem :) Thanks! |
|
Hi @siovene, I've checked the failure. The issue here is that https://github.com/ngx-formly/ngx-formly has been built with the latest Angular 13 and already uses the new definition of declarations. |
|
@satanTime thanks for checking! Turns out there were/are multiple dependencies that are not ready for Angular 13 yet :( |
|
Blocked by Mawi137/ngx-image-cropper#470 |
No description provided.