Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make sure VIRTUAL_ENV is an absolute path #224

Merged
merged 1 commit into from
Jan 6, 2025
Merged

fix: make sure VIRTUAL_ENV is an absolute path #224

merged 1 commit into from
Jan 6, 2025
+2 −2

Conversation

samypr100
Copy link
Contributor

Closes #219

@samypr100 samypr100 marked this pull request as ready for review January 4, 2025 19:10
@samypr100 samypr100 requested a review from eifinger as a code owner January 4, 2025 19:10
eifinger
eifinger approved these changes Jan 4, 2025
View reviewed changes
Copy link
Collaborator

@eifinger eifinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you!

@eifinger
Copy link
Collaborator

eifinger commented Jan 4, 2025

@charliermarsh I still can't see the button to approve the workflow runs. Can you start them?

@samypr100
Copy link
Contributor Author

@charliermarsh I still can't see the button to approve the workflow runs. Can you start them?

Looks like we should be good now

@charliermarsh charliermarsh merged commit 7768fe6 into astral-sh:main Jan 6, 2025
50 checks passed
@samypr100 samypr100 deleted the fix-venv-env-var branch January 6, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eifinger eifinger eifinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set VIRTUAL_ENV to absolute path?
3 participants
@samypr100 @eifinger @charliermarsh