Libpktriggercord #48
Closed
Libpktriggercord #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial support for library version.
These are the changes I made when I first tried to get the pktriggercord make file to compile a library version. I didn't get around to having it install the library or deal with packaging. I think part of the reason I eventually gave up was I wasn't quite sure what the preferred install/packaging behavior should be. That, and I didn't think the library would be very user-friendly without moving all of the code into a unique namespace, which I didn't feel up to doing at the time.
(The libpktriggercord package I eventually produced for INDI used a stripped down version of the source code and cmake to build/install. So that obviously wouldn't integrate well back into the original code base at the moment).