Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move data-testid to correct container #14551

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

erikdstock
Copy link
Contributor

@erikdstock erikdstock commented Sep 24, 2024

The type of this PR is: fix #minor

This PR is related to EMI-1516. A data-testid attribute is sent to the wrong element, causing tests to fail.

Copy link

relativeci bot commented Sep 24, 2024

#465 Bundle Size — 9.55MiB (0%).

f20e6f0(current) vs 5b6b59e main#456(baseline)

Warning

Bundle contains 45 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#465
     Baseline
#456
No change  Initial JS 3.95MiB 3.95MiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0.93% 0.93%
No change  Chunks 143 143
No change  Assets 146 146
No change  Modules 5636 5636
No change  Duplicate Modules 455 455
No change  Duplicate Code 5.88% 5.88%
No change  Packages 291 291
No change  Duplicate Packages 42 42
Bundle size by type  no changes
                 Current
#465
     Baseline
#456
No change  JS 9.31MiB 9.31MiB
No change  Other 237.84KiB 237.84KiB

Bundle analysis reportBranch erik.minor-shipping-quotes-test-...Project dashboard


Generated by RelativeCIDocumentationReport issue

@erikdstock erikdstock self-assigned this Sep 24, 2024
@erikdstock erikdstock merged commit acc1e1f into main Sep 24, 2024
13 checks passed
@erikdstock erikdstock deleted the erik.minor-shipping-quotes-test-id branch September 24, 2024 03:06
@artsy-peril artsy-peril bot mentioned this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant