chore: remove overfetching in ArtworkSidebarCreateAlert #14530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since revising the alert flow, this querying just for this button is no longer necessary.
#415 Bundle Size — 9.65MiB (-0.02%).a8eb026(current) vs 6650db6 main#414(baseline) Warning Bundle contains 45 duplicate packages – View duplicate packages Bundle metrics
|
| Current #415 |
Baseline #414 |
|
|---|---|---|
 Initial JS |
3.98MiB(-0.01%) |
3.98MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
4.44% |
1.72% |
| Chunks |
143 |
143 |
| Assets |
146 |
146 |
| Modules |
5634 |
5634 |
| Duplicate Modules |
455 |
455 |
| Duplicate Code |
5.87%(+0.17%) |
5.86% |
| Packages |
291 |
291 |
| Duplicate Packages |
42 |
42 |
Bundle size by type 1 change 1 improvement
| Current #415 |
Baseline #414 |
|
|---|---|---|
| JS |
9.42MiB (-0.02%) |
9.42MiB |
| Other |
233.2KiB |
233.2KiB |
Bundle analysis report Branch dblandin/artwork-sidebar-create-... Project dashboard
Generated by RelativeCI Documentation Report issue
anandaroop
approved these changes
Sep 20, 2024
anandaroop
deleted the
dblandin/artwork-sidebar-create-alert-overfetch
branch
Merged
|
@anandaroop I was looking into this data issue and just stumbled upon it. Not very scientific I'm afraid! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of this PR is: Chore
Description
Follow-up to the cleanup here. This removes some GraphQL querying that was necessary in the previous implementation.
Since revising the alert flow, most of the querying for this button is no longer necessary.