-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARX.cmake in "1.0.5.1/artoolkitX.for.Windows.v1.0.zip" contains absolut path to pthreadVC2static.lib, which is not contained #106
Comments
I Never build artoolkitx under Windows, because I have a Linux machine, for sure it is an error, maybe try to replace that line |
If I am not mistaking |
Yes, you are right for sure this is not the intended way... Sorry, i can not help much on this issue! For sure @philip-lamb or @ThorstenBux may help you. |
Im not sure if it is helpful for the issue but CMake does have generator-expressions. Instead of
it could be
The relative path would need to be composed platform dependent, e.g. for windows it would could be |
pthreads is used on Windows too via the pthreads-win32 library, which is the one that's being linked here. It's provided in the project (see https://github.com/artoolkitx/artoolkitx/blob/master/Source/depends/windows/lib/x64/pthreadVC2static.lib) but having the full path to that library in the CMake module is obviously a bug. What I'd suggest as a short-term workaround is to just copy the above library out of artoolkitx into your own link libs folder, and adjust the cmake module path. I'll have to investigate why the full path is being included. |
I downloaded "1.0.5.1/artoolkitX.for.Windows.v1.0.zip" as 1.0.6 does not have a windows download.
Found "ARX.cmake" in a sub dir and therefore wanted to use cmake's find_package:
Configuring works but if I want to build I get this error:
I looked into "ARX.cmake" and found this line.
When replacing "D:/a/1/s/Source/depends/windows/lib/x64/pthreadVC2static.lib" with "pthreadVC2static.lib" it will build but than fail to link to it. The lib is not contained in the .zip so I cannot do anything about that.
If i run build.sh in the sources the created "ARX.cmake" again contains an absolut path to the location in the source tree. Furthermore all created files are spread throughout the build dir and I cannot find install instructions anywhere which might use relative paths and copy the libs in the right place.
What is the expected way to fix? Or is there an other approach to use the sdk on windows without building it on each system?
The text was updated successfully, but these errors were encountered: