Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Exclusion Filters #705

Merged
merged 23 commits into from
Dec 29, 2020
Merged

Add Exclusion Filters #705

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
470307a
Ignore path and filename based on regex
glubsy Jul 26, 2020
a26de27
Implement dialog and base classes for model/view
glubsy Jul 28, 2020
2eaf7e7
Implement exclude list dialog on the Qt side
glubsy Aug 17, 2020
9f223f3
Concatenate regexes prio to compilation
glubsy Aug 20, 2020
3382bd5
Fix crash when recreating Results window/tab
glubsy Aug 20, 2020
26d1894
Fix tab indices not aligned with stackwidget's
glubsy Aug 23, 2020
4a1641e
Add test suite, fix bugs
glubsy Aug 29, 2020
584e9c9
Fix duplicate items in menubar
glubsy Aug 31, 2020
ea11a56
Highlight rows when testing regex string
glubsy Sep 1, 2020
18c933b
Prevent widget from stretching in layout
glubsy Sep 2, 2020
a55e02b
Fix table maximum size being off by a few pixels
glubsy Sep 2, 2020
424d34a
Add desktop.ini to filter list
glubsy Sep 3, 2020
680cb58
Merge branch 'master' into exclude_list
glubsy Oct 28, 2020
7f19647
Remove unused lines
glubsy Dec 28, 2020
07eba09
Fix error after merging branches
glubsy Dec 29, 2020
4b4cc04
Fix directories tests on Windows
glubsy Dec 29, 2020
e533a39
Remove redundant check
glubsy Dec 29, 2020
90c7c06
Merge branch 'master' into exclude_list
glubsy Dec 29, 2020
f0d3dec
Fix exclude tests
glubsy Dec 29, 2020
b5f59d2
Brighten up validation color
glubsy Dec 29, 2020
b76e866
Tweak green color on exclude table
glubsy Dec 29, 2020
39d353d
Add comment about Win7 bug
glubsy Dec 29, 2020
a93bd3a
Add missing translation hooks
glubsy Dec 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix table maximum size being off by a few pixels 
* Sometimes, the splitter doesn't fully reach the table maximum height, and the scrollbar is still displayed on the right because a few pixels are still hidden.
* It seems the splitter handle counts towards the total height of the widget (the table), so we add it to the maximum height of the table
* The scrollbar disappears when we reach just above the actual table's height
  • Loading branch information
@glubsy
glubsy committed Sep 2, 2020
commit a55e02b36d338564a5a6655842ae5e2d7e9d169b
9 changes: 4 additions & 5 deletions qt/pe/details_dialog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
QAbstractItemView, QSizePolicy, QGridLayout, QSplitter, QFrame)
from PyQt5.QtGui import QResizeEvent
from hscommon.trans import trget
from hscommon.plat import ISWINDOWS
from ..details_dialog import DetailsDialog as DetailsDialogBase
from ..details_table import DetailsTable
from .image_viewer import (
Expand Down Expand Up @@ -102,14 +101,14 @@ def resizeEvent(self, event):
self.vController.updateBothImages()

def show(self):
# Compute the maximum size the table view can reach
# Assuming all rows below headers have the same height
# Give the splitter a maximum height to reach. This is assuming that
# all rows below their headers have the same height
self.tableView.setMaximumHeight(
self.tableView.rowHeight(1)
* self.tableModel.model.row_count()
+ self.tableView.verticalHeader().sectionSize(0)
# Windows seems to add a few pixels more to the table somehow
+ (5 if ISWINDOWS else 0))
# looks like the handle is taken into account by the splitter
+ self.splitter.handle(1).size().height())
DetailsDialogBase.show(self)
self.ensure_same_sizes()
self._update()
Expand Down