Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recycle bin as a reference folder? #690

Closed
whipab opened this issue Jul 22, 2020 · 8 comments
Closed

Recycle bin as a reference folder? #690

whipab opened this issue Jul 22, 2020 · 8 comments

Comments

@whipab
Copy link

whipab commented Jul 22, 2020

Over the last few days I have used dupeguru several times to move many 10s of thousands of duplicate photos from my external drive to the recycle bin. Then As a final sweep, I selected the whole External drive to scan. When I checked the scan results, dupeguru had selected 10s of thousands of photos with photos from my recycle bin as the reference photo! If I had not been paying attention, I could have deleted all of my photos! Wtf? Dupeguru should never allow photos from the recycle bin to be selected as duplicates and certainly should NEVER choose them as the reference photos. Now I’m so nervous wondering if I may have previously accidentally done this on a previous scan. I don’t trust dupeguru anymore and want to restore all of the photos in the recycle bin. But there are so many that my computer keeps crashing.

@glubsy
Copy link
Contributor

glubsy commented Jul 22, 2020

Which operating system are you talking about? Windows?
Obviously, if you select the whole drive to scan, the trash directory will be included as well.
We probably need to add these "special directories" to a blocklist by default. Something to be done.

@whipab
Copy link
Author

whipab commented Jul 22, 2020 via email

@whipab
Copy link
Author

whipab commented Jul 26, 2020 via email

@glubsy
Copy link
Contributor

glubsy commented Jul 26, 2020

Is there a way to use dupeguru to find photos that have no duplicate

Currently no there is not. This feature has been requested before, but I suggest opening a new issue ticket since it's a totally different problem.

As a side note, I have written a patch to filter out directories such as the Windows Recycle.Bin directory which I'll submit for review soon.

@whipab
Copy link
Author

whipab commented Jul 26, 2020 via email

@glubsy
Copy link
Contributor

glubsy commented Sep 2, 2020

This issue has been addressed in #705.

@whipab
Copy link
Author

whipab commented Sep 7, 2020 via email

@arsenetar
Copy link
Owner

Closing, also as a note photo scan supports "png", "jpg", "jpeg", "gif", "bmp", "tiff", and "tif" extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants