Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes recover inconsistency with raise DSL on types other than Either #3052

Merged
merged 11 commits into from
Jun 1, 2023
Merged

Fixes recover inconsistency with raise DSL on types other than Either #3052

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5ba9f7f
WIP: Attempt at fixing ior recover issue
yoxjames May 10, 2023
a1b91db
Merge branch 'main' into fix_ior_recover
nomisRev May 25, 2023
5e26c37
Override recover vs bind to fix recover behavior and add tests to all…
yoxjames May 28, 2023
82069e8
Merge branch 'main' into fix_ior_recover
franciscodr May 29, 2023
8545448
Update API files
franciscodr May 29, 2023
d77fae7
Update arrow-libs/core/arrow-core/src/commonTest/kotlin/arrow/core/ra…
yoxjames May 30, 2023
bdda471
Removed Unnecessary Import
yoxjames May 30, 2023
0ac3dba
Update arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/ra…
yoxjames Jun 1, 2023
d4a771c
Update arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/ra…
yoxjames Jun 1, 2023
4933c52
Update arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/ra…
yoxjames Jun 1, 2023
9c02d3e
Update arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/ra…
yoxjames Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/ra… 
…ise/Builders.kt

Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com>
  • Loading branch information
@yoxjames @nomisRev
yoxjames and nomisRev authored Jun 1, 2023
commit d4a771c288c8af9a6b3055ea5f2806cfc3ca054f
2 changes: 1 addition & 1 deletion arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/raise/Builders.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ public class OptionRaise(private val raise: Raise<None>) : Raise<None> by raise
@RaiseDSL
public inline fun <A> recover(
@BuilderInference block: OptionRaise.() -> A,
@BuilderInference recover: () -> A,
recover: () -> A,
): A = when (val option = option(block)) {
is None -> recover()
is Some<A> -> option.value
Expand Down