Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same ruff version in CI and in pre-commit, reformat notebooks #334

Merged
merged 4 commits into from
Sep 15, 2024
Merged

Use same ruff version in CI and in pre-commit, reformat notebooks #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2ac8427
consistency between CI and pre-commit on used version of ruff
arogozhnikov Sep 15, 2024
5180c9a
adjust ruff setup for notebooks
arogozhnikov Sep 15, 2024
b7a094b
reformat notebooks with ruff
arogozhnikov Sep 15, 2024
d4e0dbc
adjust notebook modification for different frameworks
arogozhnikov Sep 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/run_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ jobs:
# currently there is conflict between tf, oneflow and paddle in protobuf versions.
# cupy is not tested because it demands gpu
# oneflow testing is dropped, see details at https://github.com/Oneflow-Inc/oneflow/issues/10340
# chainer testing is dropped because of conflict with numpy 2.0, see https://github.com/chainer/chainer/issues/8632
# paddle was switched off because of divergence with numpy in py3.10, paddle==2.6.1
frameworks: ['numpy pytorch tensorflow jax']

Expand All @@ -25,7 +24,7 @@ jobs:
cache: pip
- name: Check for ruff compliance
run: |
pip install ruff==0.5.7 && ruff check . && ruff format . --check
pip install ruff==0.6.5 && ruff check . && ruff format . --check
- name: Run tests
run: |
python test.py ${{ matrix.frameworks }}
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
repos:
- repo: https://github.com/astral-sh/ruff-pre-commit
# Ruff version.
rev: v0.4.2
# Ruff version, synced with CI
rev: v0.6.5
hooks:
# Run the linter.
- id: ruff
Expand Down
Loading