Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor some internals of ff #492

Merged
merged 8 commits into from
Oct 26, 2022
Merged

Refactor some internals of ff #492

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
425931a
Refactor some internals of `ff`
Pratyush Sep 29, 2022
b98e84b
Merge branch 'master' into refactor-ff-internals
weikengchen Oct 11, 2022
0b6eb95
Merge branch 'master' into refactor-ff-internals
Pratyush Oct 26, 2022
2506535
Add `Fp` by-ref operation impls
Pratyush Oct 26, 2022
6c0aaa3
Add by-ref arithmetic for Quad and Cubic Exts
Pratyush Oct 26, 2022
3e2b63a
Update CHANGELOG
Pratyush Oct 26, 2022
5262076
Fix documentation
Pratyush Oct 26, 2022
e3cb74b
Merge branch 'master' into refactor-ff-internals
Pratyush Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix documentation
  • Loading branch information
@Pratyush
Pratyush committed Oct 26, 2022
commit 5262076a3fcfc3e8344ce3b833f70edef38ce06b
6 changes: 3 additions & 3 deletions ff/src/fields/cyclotomic.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ pub trait CyclotomicMultSubgroup: crate::Field {
/// By default this is `false`, but should be set to `true` for quadratic extensions.
const INVERSE_IS_FAST: bool = false;

/// Compute a square in the cyclotomic subgroup. By default this is computed using [`Field::square`], but for
/// Compute a square in the cyclotomic subgroup. By default this is computed using [`Field::square`](crate::Field::square), but for
/// degree 12 extensions, this can be computed faster than normal squaring.
///
/// # Warning
Expand All @@ -26,7 +26,7 @@ pub trait CyclotomicMultSubgroup: crate::Field {
}

/// Square `self` in place. By default this is computed using
/// [`Field::square_in_place`], but for degree 12 extensions,
/// [`Field::square_in_place`](crate::Field::square_in_place), but for degree 12 extensions,
/// this can be computed faster than normal squaring.
///
/// # Warning
Expand Down Expand Up @@ -68,7 +68,7 @@ pub trait CyclotomicMultSubgroup: crate::Field {
result
}

/// Set `self` to be the result of exponentiating [`self`] by `e`,
/// Set `self` to be the result of exponentiating `self` by `e`,
/// using efficient cyclotomic algorithms.
///
/// # Warning
Expand Down