Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add converter between AV2 city coordinate systems, and WGS84 and UTM #28

Merged
merged 14 commits into from
Apr 12, 2022
Merged

Add converter between AV2 city coordinate systems, and WGS84 and UTM #28

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
094616d
add gps/utm converter
Mar 26, 2022
c844ffd
add missing type hints
Mar 26, 2022
d690272
add pyproj dependency
Mar 26, 2022
fd6e0cc
improve docstrings
Mar 26, 2022
817a098
reformat black
Mar 26, 2022
925ab94
add missing imports
Mar 26, 2022
33741b4
reformat python black
Mar 26, 2022
af63ba1
add Final type annotations and @unique decorator
Mar 27, 2022
afd0c12
add NDArrayFloat annotations on test cases
Mar 27, 2022
918c421
improve typing and docstrings
Mar 27, 2022
5d29a1d
remove type: ignore, as not needed in CI
Mar 27, 2022
f811951
Fix pytype
Mar 27, 2022
eecae32
fix CI
Mar 27, 2022
117f44f
switch from long -> longitude
Mar 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add missing imports
  • Loading branch information
John Lambert committed Mar 26, 2022
commit 925ab94fe09910eb413b886115ada04571fe4355
3 changes: 2 additions & 1 deletion tests/geometry/test_utm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import numpy as np

import av2.geometry.utm as geo_utils
from av2.geometry.utm import CityName, CITY_ORIGIN_LATLONG_DICT


def test_convert_city_coords_to_wgs84_atx() -> None:
Expand Down Expand Up @@ -49,7 +50,7 @@ def test_convert_city_coords_to_wgs84_wdc() -> None:


def test_convert_gps_to_utm() -> None:
""" """
"""Convert Pittsburgh city origin (given in WGS84) to UTM coordinates."""
lat, long = CITY_ORIGIN_LATLONG_DICT[CityName.PIT]
utm_coords = geo_utils.convert_gps_to_utm(lat, long, city_name=CityName.PIT)

Expand Down