Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create or use user's Session in WorkflowsService to reuse connections #1183

Merged
merged 3 commits into from
Sep 10, 2024
+259 −75
Merged

Create or use user's Session in WorkflowsService to reuse connections #1183

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49b5d5c
Add optional Session to Service to be able to reuse tcp connections
AchilleAsh Aug 31, 2024
97ecce6
Make session in service non-optional, customizable by the user
AchilleAsh Sep 9, 2024
adad63e
Fix `__exit__` code and run make codegen
elliotgunton Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix __exit__ code and run make codegen 
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
  • Loading branch information
@elliotgunton
elliotgunton committed Sep 10, 2024
commit adad63e68b267e8bfd63551d9065096209ac2ce3
2 changes: 1 addition & 1 deletion scripts/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@ def __enter__(self):

def __exit__(self, *_):
\"\"\"Close the service.\"\"\"
self.session.close()
self.close()
"""


Expand Down
2 changes: 1 addition & 1 deletion src/hera/workflows/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def __enter__(self):

def __exit__(self, *_):
"""Close the service."""
self.session.close()
self.close()

def list_archived_workflows(
self,
Expand Down
Loading