-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transaction filter working incorrectly with European timezone #62
Comments
Thanks for filing! Will try to get to it soon |
Hi @insajd
|
|
I checked IE, Firefox - same as in Chrome. |
Thanks for the info. That should be more than enough to recreate it, without needing to visit. Sorry, @DoomHammer, I'm going to have to find another excuse to get drunk in Poland with you. |
No worries 🍹 |
OK. I'm not sure if I fixed this, so you'll have to test some more. I had a lot of things going on with datetime and I think it will be easier to narrow down the issue.
If it continues to be an issue, take a screenshot of that footer and your system clock and included the relevant api calls. |
at 2 AM my local time(Riga/Latvia) I saw result of my cron job with daily transaction rate which was configured with your latest commits. cron job is run with command 0 * * * * /usr/bin/python /home/olegs/dev/manage.py transact |
Alrighty. I figured there was a good chance this was still an issue. The On Fri, Jan 8, 2016, 6:18 PM insajd notifications@github.com wrote:
|
Can you enter |
Hi, I still have a problem on my new fresh setup. I will give you access to my setup with source, where it all works that weird way. |
I was wondering if this was an issue. I think I have an idea for how to fix it. Thanks for your patience! |
I mentioned that cron for my user worked at 2 AM, but latest version from master branch actually doesn't has this problem. |
Ah. Awesome. That means we're getting closer. On Mon, Feb 8, 2016 at 2:46 AM, insajd notifications@github.com wrote:
|
I've been meaning to try Bennedetto myself for some time and since I'm also in the EU, I was wondering which branch would be currently the one to use - master or timezone-refactor? |
@rainforest1155 |
Thanks for the screenshots. |
Well this is hilarious class TimeZoneDateTimeField(serializers.DateTimeField):
def to_native(self, value):
value = timezone.localtime(value)
return super(TimeZoneDateTimeField, self).to_native(value) I put a breakpoint inside (face hits desk) |
Wrote a real TimeZoneDateTimeField serializer field and added a no-bullshit conversion to the queryset method. I'm more confident this is fixed. Try again. |
I updated the installation, will see tomorrow how new records look like. |
Hi Alex! I have tested it and it appears that part when page loads today's transactions - it works. It shows transaction which was added at something few seconds after midnight. But what is weird is that when I change data range 16-Apr till 21-Arp, I get listed records with shown within that range and also few with date as "Apr 15, 2016". Is this because those records were created when bug was not yet fixed? |
Thanks for checking that.
That is probably true. Up until this point, my serializer field was |
In Europe/Riga timezone main page shows previous day on the main page.
Example1: If currently it's 21 Dec, I login to the app(on the desktop or mobile doesn't matter), and there is filter 21 Dec-21 Dec. What I expect to see are transactions for 21 of December, but it lists transactions for 20th of December.
Probably Today field also works wrong because of this:
if at 1 AM transaction is added, it doesn't affect Today summary section.
Example2: if it's 21 Dec 1 AM, I add transaction of 100 EUR, and think I'll see Today value bump to +100EUR of previous value. But it shows the value of previous day, Dec 20.
The text was updated successfully, but these errors were encountered: